Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deferred docs #9061

Merged
merged 6 commits into from
Aug 12, 2022
Merged

add deferred docs #9061

merged 6 commits into from
Aug 12, 2022

Conversation

kentcdodds
Copy link
Member

This adds deferred docs. I haven't gotten the react router website running locally yet. I'll do that while this is getting reviewed to make sure links work and stuff.

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 97766e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kentcdodds
Copy link
Member Author

Just tried it out locally. Links work and I added line highlights 👍

brophdawg11
brophdawg11 approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

docs/components/deferred.md Outdated Show resolved Hide resolved
docs/fetch/deferred.md Outdated
@@ -0,0 +1,20 @@
---
title: deferred
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it should have new: true but I noticed none of our current "fetch utilities" have the 🆕 icon - unsure if that was on purpose or an oversight though. Will need to check with @ryanflorence. We can update them all at once in a subsequent PR if we want to add it

Kent C. Dodds and others added 2 commits July 15, 2022 16:46
@brophdawg11
Copy link
Contributor

@kentcdodds I took a pass at updating these docs based on #9095

@brophdawg11 brophdawg11 mentioned this pull request Aug 10, 2022
Closed
@ryanflorence ryanflorence merged commit 46b4936 into dev Aug 12, 2022
@ryanflorence ryanflorence deleted the deferred-docs branch August 12, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kentcdodds @brophdawg11 @ryanflorence